Audit kyuubi operation state change log #6185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
|
cc @pan3793 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6185 +/- ##
============================================
- Coverage 58.47% 58.42% -0.06%
Complexity 24 24
============================================
Files 649 650 +1
Lines 39312 39325 +13
Branches 5415 5415
============================================
- Hits 22988 22975 -13
- Misses 13856 13875 +19
- Partials 2468 2475 +7 ☔ View full report in Codecov by Sentry. |
turboFei
force-pushed
the
audit_operation
branch
from
1dba79d to
38b0192
Compare
pan3793
reviewed
Mar 18, 2024
| @@ -21,6 +21,7 @@ | |||
| <Configuration status="WARN"> | |||
There was a problem hiding this comment.
we have bunches of log4j2-test.xml, can we sync them?
There was a problem hiding this comment.
I think it is not needed, we just need to enable it in kyuubi-server side.
pan3793
approved these changes
Mar 18, 2024
cxzl25
approved these changes
Mar 18, 2024
|
Thanks, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
We meet some issue, I want to check the operation sessionHandle and the operation timeline.
I found that, it is difficult for me to check it from kyuubi log.
So, In this pr, I log the operation change log into separate file.
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.