Add log4j2 template for kyuubi repl commands #6196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
pan3793
reviewed
Mar 19, 2024
wForget
commented
Mar 19, 2024
| @@ -55,7 +55,7 @@ | |||
| <Root level="INFO"> | |||
| <AppenderRef ref="stdout"/> | |||
| </Root> | |||
| <Logger name="org.apache.kyuubi.ctl.ServiceControlCli" level="error" additivity="false"> | |||
There was a problem hiding this comment.
This class has been removed
There was a problem hiding this comment.
since you created a separate log4j2-repl.xml, do we need such conf in log4j2.xml then?
There was a problem hiding this comment.
since you created a separate
log4j2-repl.xml, do we need such conf inlog4j2.xmlthen?
I think it can be kept because user may not have created log4j2-repl.xml, in which case log4j2.xml can also be used.
There was a problem hiding this comment.
SGTM if it works, please manually check it
There was a problem hiding this comment.
SGTM if it works, please manually check it
I have tested manually and it works fine.
wForget
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6196 +/- ##
============================================
- Coverage 58.54% 58.46% -0.09%
Complexity 24 24
============================================
Files 649 649
Lines 39361 39361
Branches 5415 5415
============================================
- Hits 23045 23013 -32
- Misses 13846 13873 +27
- Partials 2470 2475 +5 ☔ View full report in Codecov by Sentry. |
pan3793
approved these changes
Mar 19, 2024
pan3793
pushed a commit
that referenced
this pull request
Mar 19, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 Add log4j2 template for kyuubi repl command. Since I want to add rolling logs for kyuubi server, we need to add independent log4j properties for kyuubi repl command. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6196 from wForget/log4j_repl. Closes #6196 d8d6464 [wforget] newline 10a5b9f [wforget] remove filter a775ee2 [wforget] Add log4j2 template for kyuubi repl command Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 31469fa) Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 Add log4j2 template for kyuubi repl command. Since I want to add rolling logs for kyuubi server, we need to add independent log4j properties for kyuubi repl command. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6196 from wForget/log4j_repl. Closes apache#6196 d8d6464 [wforget] newline 10a5b9f [wforget] remove filter a775ee2 [wforget] Add log4j2 template for kyuubi repl command Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
beryllw
pushed a commit
to beryllw/incubator-kyuubi
that referenced
this pull request
Jun 7, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 Add log4j2 template for kyuubi repl command. Since I want to add rolling logs for kyuubi server, we need to add independent log4j properties for kyuubi repl command. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6196 from wForget/log4j_repl. Closes apache#6196 d8d6464 [wforget] newline 10a5b9f [wforget] remove filter a775ee2 [wforget] Add log4j2 template for kyuubi repl command Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 31469fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
Add log4j2 template for kyuubi repl command.
Since I want to add rolling logs for kyuubi server, we need to add independent log4j properties for kyuubi repl command.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.