Add example for service monitor in Helm chart #6839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6839 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42441 42441
Branches 5793 5793
======================================
Misses 42441 42441 ☔ View full report in Codecov by Sentry. |
pan3793
reviewed
Dec 5, 2024
Signed-off-by: zhifanggao <[email protected]>
zhifanggao
force-pushed
the
add_default_endpoints
branch
from
e8db8c4 to
869f45e
Compare
pan3793
reviewed
Dec 5, 2024
pan3793
approved these changes
Dec 5, 2024
|
@zhifanggao please answer the last question in the PR template, this is mandated by the ASF and involves some legal issues. I will merge it after you complete that. |
pan3793
changed the title
Done |
|
Thanks, merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Adding an example to
servicemonitorin values.yaml to improve the usability .How was this patch tested?
execute command
helm install kyuubi-test .check the servicemonitor after deployment
Was this patch authored or co-authored using generative AI tooling?
No