-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6726][FOLLOWUP] Fix compilation on scala-2.13 #6841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6841 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42463 42463
Branches 5796 5796
======================================
Misses 42463 42463 ☔ View full report in Codecov by Sentry. |
Can we fix it in place? e.g. by adding |
pan3793
reviewed
Dec 9, 2024
pan3793
changed the title
make trino state progress available in scala-2.13
[KYUUBI #6726][FOLLOWUP] Fix compilation on scala-2.13
Dec 9, 2024
thanks, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Kyuubi supports Trino progress in scala-2.12, but got some error in scala-2.13.
Types of changes 🔖
Test Plan 🧪
Checklist 📝
Be nice. Be informative.