Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6726][FOLLOWUP] Fix compilation on scala-2.13 #6841

Closed
wants to merge 8 commits into from

Conversation

naive-zhang
Copy link
Contributor

Description

Currently, Kyuubi supports Trino progress in scala-2.12, but got some error in scala-2.13.

  • Make Trino progress available in scala-2.13

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (dc3ac89) to head (0693d28).
Report is 3 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6841   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         687     687           
  Lines       42463   42463           
  Branches     5796    5796           
======================================
  Misses      42463   42463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793
Copy link
Member

pan3793 commented Dec 9, 2024

Can we fix it in place? e.g. by adding .Seq to make the collection conversion work in both Scala 2.12 and 2.13

@pan3793 pan3793 changed the title make trino state progress available in scala-2.13 [KYUUBI #6726][FOLLOWUP] Fix compilation on scala-2.13 Dec 9, 2024
@pan3793 pan3793 added this to the v1.11.0 milestone Dec 9, 2024
@pan3793
Copy link
Member

pan3793 commented Dec 9, 2024

thanks, merged to master

@pan3793 pan3793 closed this in 62c06ad Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants