Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional labels for PodMonitor to be discovered by Prometheus #6845

Closed
wants to merge 2 commits into from

Conversation

eric9204
Copy link
Contributor

@eric9204 eric9204 commented Dec 9, 2024

Why are the changes needed?

the prometheus can not discover the podMonitor created by kyuubi helm chart.

How was this patch tested?

  1. enable pod monitor:
metrics:
  # Enable metrics system, used for 'kyuubi.metrics.enabled' property
  enabled: true
  # A comma-separated list of metrics reporters, used for 'kyuubi.metrics.reporters' property
  reporters: PROMETHEUS
  # Prometheus port, used for 'kyuubi.metrics.prometheus.port' property
  prometheusPort: 10019

  # PodMonitor by Prometheus Operator
  podMonitor:
    # Enable PodMonitor creation
    enabled: true
    # List of pod endpoints serving metrics to be scraped by Prometheus, see Prometheus Operator docs for more details
    #podMetricsEndpoints: []
    podMetricsEndpoints:
      - path: /metrics
        port: prometheus
  1. Helm install kyuubi .
  2. check prometheus web ui.

Was this patch authored or co-authored using generative AI tooling?

No

@eric9204 eric9204 changed the title add labs to podmonitor for discover it by prometheus add labels to podmonitor for discover it by prometheus Dec 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (99e27d4) to head (f8fa51f).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6845   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         687     687           
  Lines       42463   42463           
  Branches     5796    5796           
======================================
  Misses      42463   42463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

charts/kyuubi/values.yaml Outdated Show resolved Hide resolved
@pan3793 pan3793 changed the title add labels to podmonitor for discover it by prometheus Support additional labels for PodMonitor to be discovered by Prometheus Dec 10, 2024
@pan3793 pan3793 added this to the v1.11.0 milestone Dec 10, 2024
@pan3793 pan3793 closed this in ee7e234 Dec 10, 2024
@pan3793
Copy link
Member

pan3793 commented Dec 10, 2024

thanks, merged to master

@eric9204 eric9204 deleted the add-lab-to-pm branch December 10, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants