Skip to content

Fix ArrayIndexOutOfBoundsException in ThrowableStackTraceRenderer when the stack trace is mutated concurrently #3955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: 2.x
Choose a base branch
from
Open

Fix ArrayIndexOutOfBoundsException in ThrowableStackTraceRenderer when the stack trace is mutated concurrently #3955

wants to merge 6 commits into from
+121 −55

Conversation

mosche
Copy link
Member

@mosche mosche commented Oct 14, 2025 •
edited by vy
Loading

Fix ArrayIndexOutOfBoundsException in ThrowableStackTraceRenderer if concurrently modifying the stack trace of a Throwable while rendering it

Closes #3940

This was referenced Oct 14, 2025
Open
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
Generated by gradle/develocity-actions

@vy vy self-assigned this Oct 15, 2025
@vy vy changed the title Fix ArrayIndexOutOfBoundsException in ThrowableStackTraceRenderer when concurrently mutating the stacktrace Fix ArrayIndexOutOfBoundsException in ThrowableStackTraceRenderer when the stack trace is mutated concurrently Oct 17, 2025
vy
vy approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosche, thanks so much for the contribution. I've confirmed that both tests (the new one, and the old one of #3929) fail in the absence their associated fixes.

@vy vy enabled auto-merge (squash) October 17, 2025 13:04
@mosche
Copy link
Member Author

mosche commented Oct 17, 2025

Ugh, sorry, I missed configuring git to sign commits for this repo. My bad! Are you ok if I rewrite the history here? Sorry for that, you'll have to fix your commits afterwards then

@mosche
Copy link
Member Author

mosche commented Oct 17, 2025

Thanks for the quick response here btw!

@vy
Copy link
Member

vy commented Oct 17, 2025

@mosche, yes, you must override the history. Please keep the content intact. git rebase -i HEAD~6 && git push -f origin 3940_fix_ThrowableStackTraceRenderer should do the trick. You can also squash all in one commit – but keep the diff intact.

auto-merge was automatically disabled October 17, 2025 18:20

Head branch was pushed to by a user without write access

@mosche mosche force-pushed the 3940_fix_ThrowableStackTraceRenderer branch from 5d64cca to f208e1b Compare October 17, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vy vy vy approved these changes

Assignees

@vy vy

Labels

None yet

Projects

Log4j bug tracker
Status: To triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ThrowableStackTraceRenderer can throw an ArrayIndexOutOfBoundsException when rendering a Throwable with a concurrently-mutated stacktrace

2 participants

@mosche @vy