-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds github action to verify changelog entry and set milestone to PRs #14279
base: main
Are you sure you want to change the base?
Adds github action to verify changelog entry and set milestone to PRs #14279
Conversation
cded4ed
to
55d89f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work and really helpful @pseudo-nymous! I left some comments, but I'm looking forward to seeing this in action.
fd02d5f
to
00c4469
Compare
…omment out pr milestone edit line for now
00c4469
to
ce605d2
Compare
Please do not force-push your changes. Keep prior commits so that the history is preserved and comments are attached where they should be. Thanks! |
There were small fixes which I missed in previous commit. This didn't had any history attached to it and I kept the commit which had comments. Also, I'll keep this in check in next time. Thanks |
Thank you for making the changes @pseudo-nymous! I think once we make the action use the new label I created we're ready to test this out. |
I have updated the script to use new label. We are ready to test the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! If no one objects, I'll merge in the next few days and we can see how it runs. If we like what we see in the logs, we can come back and enable it to set milestones and comment on the PR.
Description
Adds github action workflow to verify change log entry and set milestone based on the location of change log entry.
This workflow does the following step by step:
skip changelog
label to skip the further steps.Committers should add this label if they want skip adding change log entry
. This is helpful when change log entry is not required.Currently, I have only added logs in the action workflow testing all the flow. It's not blocking the merging process.
We can make it blocking based on the discussion in this PR.
Tested changes here: pseudo-nymous#13
Closes: #13898 #14190