Skip to content

[Build] [DO NOT MERGE YET] Refactor validation-jar checks #14861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

breskeby
Copy link
Contributor

This is a work in progress on reworking licence checks. It aims for:

  • extract imperative code into binary plugin
  • replace internal state across validation tasks
  • fix deprecated usage of project object in task execution phase.

Originally motivated to remove deprecation warnings about

Turns imperative logic into a binary plugin;
Addresses also deprecated behavior of referencing project at
task execution time
@breskeby
Copy link
Contributor Author

This is totally WIP and I raised the PR early here to give a heads up that I'm looking in reworking these parts of the build. Will ping again when I have something worth to share and ready for review.

- keep compatible with other validation tasks for now
- serialize as json file as output of collectJarInfo
@dweiss
Copy link
Contributor

dweiss commented Jun 29, 2025

This part is a beast - thank you for trying to untangle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants