Add test to check return values of frequency and norm when there are no frequencies #15266
Conversation
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
|
|
||
| protected boolean indexFakeImpacts() { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
should we remove this and fix all postings formats that don't pass the test?
There was a problem hiding this comment.
That sounds a good idea although my knowledge about them is very shallow, e.g. I am not sure what is the right way to detect that a field has no frequencies.
There was a problem hiding this comment.
Typically you would check FieldIndex#indexOptions. If the value is DOCS, then frequencies are not indexed.
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
4 participants
It has happened a couple of times that we returned a wrong value here so let's make sure we have it covered.