Skip to content

Conversation

vijaykriishna
Copy link

@vijaykriishna vijaykriishna commented Oct 4, 2025

Title: [#13710] refactor(PointRangeQuery): Refactor PointRangeQuery to separate createWeight function implementtion to PointRangeWeight using PointQueryUtils.

Description

This PR refactors the Lucene core point range query implementation to improve code reuse and maintainability:

  • Introduced: PointQueryUtils utility class to encapsulate common logic for validating point values and determining spatial relations between query ranges and indexed point ranges.
  • Updated: PointRangeQuery and PointRangeWeight to use methods from PointQueryUtils instead of duplicating logic.
  • Added and Improved: Javadocs for PointRangeWeight, PointQueryUtils, and the new package org.apache.lucene.util.search.
  • Exported: org.apache.lucene.util.search package in the module descriptor to resolve modular test failures.
  • Ensured all usages of point range validation and relation checks are routed through the new utility class for consistency.

This refactoring does not change any external behaviour but improves code clarity, testability, and modularity. All existing tests pass.

Copy link
Contributor

github-actions bot commented Oct 4, 2025

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

Copy link
Contributor

github-actions bot commented Oct 4, 2025

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant