Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Use BOM-less UTF-8 encoding for writes, #1027 #1075

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Use BOM-less UTF-8 encoding for writes

Fixes #1027

Description

See #1027 for details.

@paulirwin paulirwin added the notes:bug-fix Contains a fix for a bug label Dec 24, 2024
@paulirwin paulirwin marked this pull request as ready for review December 24, 2024 23:52
@paulirwin
Copy link
Contributor Author

@NightOwl888 I assume this comment on the issue was really for this PR instead: #1027 (comment)

I went ahead and took option 1 to remove the field, and renamed CHARSET_UTF_8 as you noted as well. For consistency with use elsewhere and in Lucene, I left an underscore between "UTF" and "8" as ENCODING_UTF_8_NO_BOM.

@paulirwin paulirwin added notes:breaking-change Has changes that will break backward compatibility and removed notes:bug-fix Contains a fix for a bug labels Dec 31, 2024
@paulirwin paulirwin changed the title SWEEP: Use BOM-less UTF-8 encoding for writes, #1027 BREAKING: Use BOM-less UTF-8 encoding for writes, #1027 Dec 31, 2024
@paulirwin paulirwin merged commit 12b8941 into apache:master Jan 6, 2025
267 checks passed
@paulirwin paulirwin deleted the issue/1027 branch January 6, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:breaking-change Has changes that will break backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review all Encoding usage for BOM compatibility
2 participants