Simplify IndexReader constructor, #919 #1081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify IndexReader constructor.
Fixes #919
Description
This removes the type check in the IndexReader constructor that ensures that only CompositeReader and AtomicReader are allowed subtypes. This is not needed since in C# we can use the
private protected
modifier to ensure that no outside classes can subtype this. This removes the need for the runtime check in the constructor, which will mildly improve performance. A comment was left explaining the divergence with the original commented-out code.