Skip to content

Conversation

@AnastasiaJacson
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)
Changed the HttpClientBase.ExecutePost to accept any kind of HttpContent and removed Newtonsoft Nuget reference.

Fixes #1176 (in this specific format)

Description

Changed the HttpClientBase.ExecutePost to accept any kind of HttpContent and removed Newtonsoft Nuget reference. Now it is not dependent on Newtonsoft.Json and better matches the upstream (see).

@paulirwin paulirwin self-assigned this Oct 27, 2025
@paulirwin paulirwin self-requested a review October 27, 2025 14:03
@paulirwin paulirwin added the notes:improvement An enhancement to an existing feature label Oct 27, 2025
@paulirwin
Copy link
Contributor

Hi @AnastasiaJacson - thanks for this PR! Unfortunately we have a little bit of a conflict as some of the work for this was done in #1182. I'm going to see what I can do to balance the work between these so that both can be merged. My current thinking is I'll work on merging this one first, then work with @NehanPathan to update #1182 since it touches on some different aspects. Thanks!

Copy link
Contributor

@paulirwin paulirwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Since you enabled edits by maintainers, I went ahead and did some minor cleanup of HttpClientBase and HttpReplicator that inherits from it. Some comments were no longer relevant with this PR, and the classes in general just needed some cleanup.

I also removed the Newtonsoft.Json dependency version from .build/dependencies.props since that is no longer needed.

@AnastasiaJacson
Copy link
Contributor Author

Thanks! Yeah, that cleanup helped with code clarity)

@paulirwin paulirwin merged commit f4cb566 into apache:master Oct 28, 2025
276 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:improvement An enhancement to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change HttpClientBase.ExecutePost to match upstream better and drop Newtonsoft.Json dependency

2 participants