Temporary thread safety fix for ICUTokenizer/Locking patches for AttributeSource #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o account for the latest features of ICU
…try catch and replaced ContainsKey with TryGetValue
…ved extra lookup by using TryGetValue
…make the get/update process of creating an attribute WeakReference atomic
… Use external lock for better performance and removed redundant GetOrAdd() call
… thread to manipulate the BreakIterator at a time. This helps, but is only a partial fix.
…w a single thread to manipulate the BreakIterator at a time. This can be reverted when the BreakIterator issue is fixed.
29 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes thread safety with
ICUTokenizerand makes it pass theTestRandomStringsandTestRandomHugeStringsof bothTestICUTokenizerandTestICUTokenizerCJKtest classes (see #269). This serves as proof that thread safety is broken in ICU4N's BreakIterator and the patch can be reverted once the thread safety issues have been addressed in ICU4N.The
ThaiTokenizeris also patched slightly better here, but it still occasionally fails theTestRandomStringsandTestRandomHugeStringstests (see #269).This PR also contains some performance improvements for
AttributeSourcethat make the tests less likely to run slow due to threading contention issues or unnecessary dictionary lookups.