-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate benchmark.net project to run against code and not nuget packages #349
base: benchmarkdotnet
Are you sure you want to change the base?
Add separate benchmark.net project to run against code and not nuget packages #349
Conversation
…include beta 5, beta 6, and beta 10
Thanks for putting together this PR. We definitely need benchmarks in the master branch. However, what we ought to shoot for are benchmarks that can be run by developers, added to a nightly builds and release builds, and also plan for future expansion to benchmark individual components of individual assemblies. I like the precedent set forth in NodaTime.Benchmarks. A few things to consider:
Of course, a key part of getting this into the build is to set up the instrumentation so the benchmark results are easily available for viewing (ideally without having to download the artifacts). This was dirt simple in TeamCity by including an HTML file as a tab in the portal, but we haven't explored the options yet in Azure DevOps. We are running into a realistic limit of number of projects Visual Studio can load in a reasonable timeframe, so ideally we would keep them in a separate You don't need to include all of these changes in this PR, this is just to outline the plan. But could you please set a precedent by putting the benchmarks in a top level
|
@NightOwl888 seems like a good vision for benchmarking. |
…tly build to reduce testing time
…ild to reduce testing time
9cd3408
to
549070d
Compare
549070d
to
55e8034
Compare
@NightOwl888 found it useful to be able to run the same benchmarks against the code instead of against the nuget packages