Leave debugStream as null on construction of parser token managers #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When debugStream is set to Console.Out by default, StandardSyntaxParserTokenManager throws an exception when constructing a StandardQueryParser on OSes that do not support System.Console, such as iOS and Android. * debugStream can be set later using the setter, if needed. * The above is the same for QueryParserTokenManager when constructing a QueryParser. * See issue apache#936 for details.
Otherwise the following error occurs when attempting to publish to the iOS App Store: Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90, 5): [NETSDK1124] Trimming assemblies requires .NET Core 3.0 or higher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Leave debugStream as null on construction of parser token managers.
Fixes #{bug number} (in this specific format)
Fixes #936
Description
{Detail}
debugStreamis set toConsole.Outby default,StandardSyntaxParserTokenManagerthrows an exception when constructing aStandardQueryParseron OSes that do not support System.Console, such as iOS and Android.debugStreamcan be set later using the setter, if needed.QueryParserTokenManagerwhen constructing aQueryParser.