-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARCHETYPE-311] Add feature to create base dir #36
base: master
Are you sure you want to change the base?
Conversation
* WIP: test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A must for me!
...mon/src/main/java/org/apache/maven/archetype/generator/DefaultFilesetArchetypeGenerator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have at least a JIRA issue and likely should be dicussed on the dev mailing list first.
return createBaseDir; | ||
} | ||
|
||
public ArchetypeGenerationRequest setCreteBaseDir( boolean createBaseDir ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HEre is a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:o yes, i need fix it ,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-o you can review now, please
This a related jira issue , i don't know if what is you need @elharo . |
@ripper2hl ARCHETYPE-311 doesn't seem to be for this. It is in the same area, but 311 is a bug "Basedir property in archetype:generate cannot be overriden", not a new feature. Does this fix the bug and add a feature? |
@dhutchison this add the posibilty to create an project on the same directory, without create an subdirectory. |
For now when you create an project always generate a directory with the name of the artifact but in some case this is not required.
You can see https://stackoverflow.com/questions/24399613/using-maven-archetype-generate-in-the-same-directory
Work-in-Progress.
If this a bad approach let me know please.