-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace #65
base: master
Are you sure you want to change the base?
Conversation
Looks like it fails on JDK 11+ https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-archetype/job/linebreak/1/testReport/ |
Yep:
|
It might make sense to create a new Java 11 test rather than changing this one. |
I don't see what you try to achieve or what your reasoning is here. However, the call to You can see it here: bf79618#diff-db4ddee9a40aadf3fab866c350ca950397f69b630de05a126f0265e2136cc070 |
I'm trying to understand what's going on here, and how it fails. This is easier to do one change at a time. This test isn't very well factored to start with, and might need some cleanup before the issue can be fixed. |
Right, that is always a good approach to solve a bug. I would hope that the existing PR is a reasonable starting point on how to fix the bug and my comment in JIRA points to the commit that most likely causes the bug. Anyway, I wish you good luck with the approach you apply to the problem. :) |
I think you've identified the likely cause of the bug. I do not, however, agree with the proposed fix. There's nothing about this bug that suggests we should be adding schema processing. I'll be quite surprised if that turns out to be necessary. |
@newur @Tibor17
Passes in Java 8. I want to see if this fails in Java 11.