Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Sisu Guice instead of Plexus #127

Merged
merged 6 commits into from
Dec 24, 2024
Merged

Use Sisu Guice instead of Plexus #127

merged 6 commits into from
Dec 24, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Nov 21, 2024

No description provided.

@elharo elharo marked this pull request as ready for review November 21, 2024 20:23
slawekjaranowski
slawekjaranowski previously requested changes Dec 7, 2024
View reviewed changes
src/main/java/org/apache/maven/plugins/help/DescribeMojo.java Outdated
@@ -126,6 +128,20 @@ public class DescribeMojo extends AbstractHelpMojo {
@Component
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Component annotation should be removed and field can be final

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@elharo elharo merged commit d0cf89c into master Dec 24, 2024
51 checks passed
@elharo elharo deleted the guice2 branch December 24, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz approved these changes

@slawekjaranowski slawekjaranowski slawekjaranowski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elharo @slawekjaranowski @slachiewicz