Switch the build to using Maven 4 and the 4.1.0 model #1175
Conversation
|
BOM GA's changed, this PR will now fail with beta-5 unless updated |
agent/pom.xml
Outdated
| @@ -16,14 +16,10 @@ | |||
| limitations under the License. | |||
|
|
|||
| --> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | |||
| <project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 http://maven.apache.org/maven-v4_1_0.xsd"> | |||
There was a problem hiding this comment.
I think the correct location for the XSD is https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd. The current URL gives a HTML page with "Not found".
There was a problem hiding this comment.
That's right, it needs to be fixed.
However, I think we did set up a redirection and https://maven.apache.org/xsd/maven-4.1.0.xsd will redirect to latest beta. I can't find out where this redirect source is...
There was a problem hiding this comment.
So http://maven.apache.org/maven-v4_0_0.xsd also redirects to https://maven.apache.org/xsd/maven-4.0.0.xsd ...
There was a problem hiding this comment.
agent/pom.xml
Outdated
| <artifactId>mvnd</artifactId> | ||
| <version>2.0.0-beta-2-SNAPSHOT</version> | ||
| </parent> | ||
| <modelVersion>4.1.0</modelVersion> |
There was a problem hiding this comment.
This can be inferred from the XSD, so we could drop it.
build-plugin/pom.xml
Outdated
client/pom.xml
Outdated
common/pom.xml
Outdated
| @@ -55,11 +51,6 @@ | |||
| <artifactId>junit-jupiter</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Is this dependency not necessary anymore? The change seems unrelated to me...
| <version>${project.version}</version> | ||
| <groupId>org.assertj</groupId> | ||
| <artifactId>assertj-core</artifactId> | ||
| <version>${assertj.version}</version> |
There was a problem hiding this comment.
Can we add <scope>test</scope> here?
gnodet
force-pushed
the
switch-pom-to-mvn4
branch
2 times, most recently
from
b878f40 to
f9c52f1
Compare
gnodet
force-pushed
the
switch-pom-to-mvn4
branch
from
f9c52f1 to
97e9cde
Compare
This PR obviously needs a CI change to build with 4.0.0-beta-5, but it serves as a testing for apache/maven#1818