Upgrade to Maven 4.0.0-rc-1 #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2024
|
All fine, manually tested as well, but one problem (and related IT) fails: raw streams OTOH, the IMO this is a problem in maven and not mvnd. |
This was referenced Nov 22, 2024
|
All looks good, tested locally. |
cstamas
reviewed
Nov 22, 2024
cstamas
reviewed
Nov 22, 2024
| terminal -> doConfigureWithTerminal(context, terminal)); | ||
| context.terminal = MessageUtils.getTerminal(); | ||
| context.closeables.add(MessageUtils::systemUninstall); | ||
| MessageUtils.registerShutdownHook(); |
There was a problem hiding this comment.
We should remove this from here, and install it only once in LookupInvoker maybe?
There was a problem hiding this comment.
Maven 3 did not create a Terminal, so this was needed. But now it should go away.
There was a problem hiding this comment.
I'd leave all this as is, as shutdown hook is also removed on uninstall, hence IMO we are ok. Also, mvnd creates "exec" terminal while mvn not.
We can further simplify later.
cstamas
reviewed
Nov 22, 2024
Merged
gnodet
force-pushed
the
beta-6
branch
2 times, most recently
from
f7a0bed to
62ab9a8
Compare
nano time is not enough, rather use a "sequence"
# Conflicts: # pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates mvnd to Maven 4.0.0-rc-1