Update README.adoc #925
Merged
Update README.adoc #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nathansit
commented
Mar 14, 2024
nathansit
commented
- Just fixed some typos
- Adjusted some wording
- Feel free to accept whichever parts make sense (if any)
ppalaga
requested changes
Mar 15, 2024
| @@ -70,7 +69,7 @@ $ brew install mvndaemon/homebrew-mvnd/mvnd | |||
|
|
|||
| We're looking for contribution to support https://www.macports.org[MacPorts], | |||
| https://community.chocolatey.org/packages/mvndaemon/[Chocolatey], https://scoop.sh/[Scoop] or | |||
| https://github.com/joschi/asdf-mvnd#install[asdf]. If you're fancy helping us... | |||
| https://github.com/joschi/asdf-mvnd#install[asdf]. If you fancy helping us... | |||
There was a problem hiding this comment.
-1 on this change. The original was correct IMO.
There was a problem hiding this comment.
I'm not a native speaker, but IIUC the original is incorrect, and the suggestion is correct. See also examples e.g. here.
There was a problem hiding this comment.
I can see it being written as "If you are fancy, help us" or something along those lines. But I haven't heard that turn of phrase too often either.
There was a problem hiding this comment.
Thanks for pointing to an evidence, gentlemen. I did not know "fancy" was also a verb.
Stephan202
reviewed
Mar 16, 2024
nathansit
force-pushed
the
patch-3
branch
2 times, most recently
from
f5ce3eb to
c3831bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.