[MRESOLVER-377] Introduce metadataUpdatePolicy #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the policies applied in case of data and metadata application. --- https://issues.apache.org/jira/browse/MRESOLVER-377
michael-o
reviewed
Jun 29, 2023
| @@ -94,7 +94,7 @@ public interface RepositorySystemSession { | |||
| String getChecksumPolicy(); | |||
|
|
|||
| /** | |||
| * Gets the global update policy. If set, the global update policy overrides the update policies of the remote | |||
| * Gets the global data update policy. If set, the global update policy overrides the update policies of the remote | |||
There was a problem hiding this comment.
IMHO, "data", as we call consequently the other "metadata" everywhere. Yes, in resolver, "data" is "artifact", but the point is, it does not have to be only that. Hence I went with generic "data" and "metadata".
|
Shouldn't that be targeted for 1.10 ? |
|
Really does not matter, as if you do updatePolicy == metadataUpdatePolicy, you are back to "old behaviour", like this PR did not exist even. But agree, it could go to 1.10 as well... |
|
The crux of this change is really just to introduce two policies (in parallel), but if application using resolver decides to use same policy for both, the original behavior of resolver returns and will behave as before (ie. like 1.9.x does) |
Instead, make javadoc clear this ctor enables "old" behaviour, as maybe that is some wants. Also, migrated code will not get deprecation warnings like this, as using this ctor is really "legal" in a sense, is still okay to use it IF this is what you want.
maven-resolver-api/src/main/java/org/eclipse/aether/repository/RepositoryPolicy.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the policies applied in case of data and metadata, allowing greater control of their updates. Still, work "as before" in case of applications that migrate from 1.x resolver (they should receive no behavior change).
The crux of this change is really just to introduce two policies (to co-exist in parallel), but if application using resolver decides to use same policy for both, the original behavior of resolver returns and will seemingly behave as before (ie. like 1.9.x does).
Maven relies on metadata in these cases ONLY:
Resolver OTOH provides one more use case:
Now, while Maven Core itself does NOT use 3rd use case, some plugins does, most notably the versions-maven-plugin. Today, everyone on Earth use this plugin along with
-UMaven switch to pick up new stuff from remote repository, but this is total overkill, as it refreshes everything (yes, even the immutable release artifacts!). The-Uis simply a "must", to make Maven "refresh metadata" (as well, along with all the Artifacts) to pick up new versions on remote. Versions plugin did implement a "hack" to overcome this limitation, that is still a hack, as it still applies to everything. Proper solution is to have means to express-U but for metadata only. This PR makes this possible on resolver side.https://issues.apache.org/jira/browse/MRESOLVER-377