Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-8437] mvnsh #1982

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

[MNG-8437] mvnsh #1982

wants to merge 19 commits into from
+1,295 −663

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Dec 13, 2024 •
edited
Loading

The beginning

https://asciinema.org/a/KxFoz2NUyI0joa4kM4ZRRCJgD

Changes:

  • (unrelated) contains fix for property handling in embedded executor and in lookup invoker
  • pulled -o (offline) option to "generic" Options from MavenOptions
  • introduce mvnsh (scripts, options, CLIng main class)
  • simplified invokers (only one context needed for maven now)
  • invokers made "reentrant", it all depends HOW context is created

Related PRs:

https://issues.apache.org/jira/browse/MNG-8437

@cstamas
mvnsh
9ccbf63 
The beginning
@cstamas cstamas requested a review from gnodet December 13, 2024 21:36
@cstamas cstamas self-assigned this Dec 13, 2024
@cstamas cstamas mentioned this pull request Dec 14, 2024
Open
@cstamas cstamas mentioned this pull request Dec 15, 2024
Draft
@cstamas cstamas changed the title mvnsh [MNG-8437] mvnsh Dec 16, 2024
@cstamas cstamas marked this pull request as ready for review December 16, 2024 14:20
@cstamas cstamas added this to the 4.0.0-rc-3 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnodet gnodet Awaiting requested review from gnodet

Assignees

@cstamas cstamas

Labels
None yet
Projects
None yet
Milestone
4.0.0-rc-3
Development

Successfully merging this pull request may close these issues.
1 participant
@cstamas