Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8438] maven-jline: Migrate to Maven DI (off javax.inject) #1987

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Dec 16, 2024

@cstamas cstamas requested a review from gnodet December 16, 2024 13:19
@cstamas cstamas self-assigned this Dec 16, 2024
@cstamas cstamas marked this pull request as ready for review December 16, 2024 15:15
@cstamas cstamas added this to the 4.0.0-rc-3 milestone Dec 16, 2024
@slachiewicz
Copy link
Member

How all this would work - we have many external components that in theory should work outside of Maven world, based on javax.inject.
If we say that's only theory - should components migrate to Maven DI?

@cstamas
Copy link
Member Author

cstamas commented Dec 16, 2024

Maven4 "core" (the new one, impl/maven-impl) is already Maven DI, while "old core" (impl/maven-core) is still sisu DI. Still, there is a "bridge" that makes Maven DI components visible to Sisu, hence "everything work" even if "new core" is already Maven DI.

For outside of Maven (this repo), Maven4 stuff can already migrate to Maven DI, while stuff requiring Maven 3 AND 4 support should remain on Sisu as that is the common denominator of two.

@cstamas cstamas changed the title [MNG-8438] Migrate off javax.inject [MNG-8438] maven-jline: Migrate to Maven DI (off javax.inject) Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants