Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8473] Site fixes #2010

Merged
merged 2 commits into from
Jan 8, 2025
Merged

[MNG-8473] Site fixes #2010

merged 2 commits into from
Jan 8, 2025

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Dec 23, 2024

Maven4 site cleanup: make all new modules generating models also document them, expose them all and redirect all links to new documentation.

Lifecycle is the only thing missing, as it is generated on the fly, there is no more source to "point at"...


https://issues.apache.org/jira/browse/MNG-8473

@cstamas cstamas added this to the 4.0.0-rc-3 milestone Dec 23, 2024
@cstamas cstamas self-assigned this Dec 23, 2024
@cstamas cstamas changed the title Restore some links Site fixes Dec 27, 2024
@cstamas cstamas changed the title Site fixes [MNG-8473] Site fixes Dec 28, 2024
@cstamas cstamas marked this pull request as ready for review January 6, 2025 17:01
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not pointing at:

They are not much readable for non developers, but maybe our target would know enough ?

The changes to the modello generation leads to unneeded processing if not building the site. That was done on purpose to simplify the config ?

@cstamas
Copy link
Member Author

cstamas commented Jan 7, 2025

re "unneeded processing": exactly, I don't care if XSD is being built but unused, what I do care about is simple POM.
re "pointing": i agree, why not. Before the class was literally "listing" phases...

Some links like settings, toolchains and lifecycles were
broken.
@cstamas cstamas merged commit 71c662f into apache:master Jan 8, 2025
13 checks passed
@cstamas cstamas deleted the site-fixes branch January 8, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants