[MNG-8475] In the loop scenario, StringBuilder is used instead of concatenation #2014
+27
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…catenation Signed-off-by: crazyhzm <[email protected]>
michael-o
approved these changes
Jan 1, 2025
gnodet
requested changes
Jan 7, 2025
| if (executionIdx > 0) { | ||
| goal = goal.substring(0, executionIdx); | ||
| goal = new StringBuilder(goal.substring(0, executionIdx)); |
There was a problem hiding this comment.
That looks inefficient, use goal.setLength(executionIdx);
| @@ -216,9 +216,9 @@ public MojoDescriptor getMojoDescriptor(String task, MavenSession session, Maven | |||
| plugin = findPluginForPrefix(prefix, session); | |||
| } | |||
|
|
|||
| int executionIdx = goal.indexOf('@'); | |||
| int executionIdx = goal.toString().indexOf('@'); | |||
There was a problem hiding this comment.
I think wrt performances, it would be better to use goal.indexOf("@")
| @@ -138,7 +138,7 @@ public MojoDescriptor getMojoDescriptor(String task, MavenSession session, Maven | |||
| throws PluginNotFoundException, PluginResolutionException, PluginDescriptorParsingException, | |||
| MojoNotFoundException, NoPluginFoundForPrefixException, InvalidPluginDescriptorException, | |||
| PluginVersionResolutionException { | |||
| String goal = null; | |||
| StringBuilder goal = null; | |||
There was a problem hiding this comment.
I think creating the new StringBuilder() here and use append in the 5 locations below instead of constructing a new StringBuilder would make the code more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under loops, string concatenation using StringBuilder performs better.