-
Notifications
You must be signed in to change notification settings - Fork 2.7k
avoid false IO
catch on mkdirs()
#2396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pankraz76
wants to merge
1
commit into
apache:master
Choose a base branch
from
Pankraz76:avoid-unnecessary-catch-on-mkdirs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
avoid false IO
catch on mkdirs()
#2396
Pankraz76
wants to merge
1
commit into
apache:master
from
Pankraz76:avoid-unnecessary-catch-on-mkdirs
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkdirs()
IO
catch on mkdirs()
is this any good? |
elharo
reviewed
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Most comments are the same across the files
...aven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java
Show resolved
Hide resolved
its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java
Show resolved
Hide resolved
...in-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
Show resolved
Hide resolved
...aven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
...in-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java
Outdated
Show resolved
Hide resolved
...ven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
...tubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java
Outdated
Show resolved
Hide resolved
...re-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java
Outdated
Show resolved
Hide resolved
...-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java
Show resolved
Hide resolved
dd3aa4d
to
c642b8b
Compare
Pankraz76
commented
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...aven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
...ven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
c642b8b
to
469a8e6
Compare
elharo
requested changes
May 28, 2025
its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java
Show resolved
Hide resolved
...maven-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java
Show resolved
Hide resolved
This was referenced May 28, 2025
469a8e6
to
6502d96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractMojo#mkDirForParentFile(File)
central fixtry
can useautomatic resource management
#2395