MYFACES-4695: Allow searching for ids with separator character [5.0]

[volosied]

No description provided.

[tandraschko]

We need a unittest for this case before applying here something

[volosied]

I'll add it next. Just making sure the change looks okay and the existing tests pass.

[volosied]

Added a test -- without my fix it fails with

[ERROR] Errors: 
[ERROR]   SearchExpressionImplTest.testMyFaces4695:423 » ComponentNotFound Cannot find component for expression "form1:one" referenced from "form2:submit".
[INFO] 

[tandraschko]

i dont think the case is valid, it needs to be
<f:ajax render=":form1:one" />

[volosied]

I see this as more of a convenience.

The spec describes the search algorithm here: https://jakarta.ee/specifications/faces/4.1/apidocs/jakarta.faces/jakarta/faces/component/search/searchexpressionhandler

However, it also states "The search algorithm must operate as follows, though alternate algorithms may be used as long as the end result is the same:"

If the component can't be found, then it will throw an exception (due to your change), but, in my opinion, it should keep searching, if possible, to find the component.

As for the code, we do a bottom - up search (see this line)

if we can't find the component, should we use try from the root instead?

Let me know what you think. Thanks

[tandraschko]

its clearly described in the specs:
Otherwise, search up the parents of this component. If a [NamingContainer](https://docs.oracle.com/javaee/7/api/javax/faces/component/NamingContainer.html) is encountered, it will be the base.

https://docs.oracle.com/javaee/7/api/javax/faces/component/UIComponentBase.html#findComponent-java.lang.String-

[tandraschko]

and its like this for ages, in both JSF impls and also in the past in the native PF expressions
either we dont support it or we add a config, disabled per default, to allow this

[volosied]

One more data point -- this previously worked in 2.2, but then changed in 2.3 due to addition of the SearchExpressionHandler API.

[tandraschko]

i think it was a hack around it, it matches your example:
https://github.com/apache/myfaces/blob/2.2.x/impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java#L498

[tandraschko]

im really happy that both myfaces and mojarra uses almost the exact same impl for this very old topic and that we could even remove the native PF expressions

if add such a hack again, we should make it disabled per default, just to allow users to migrate their old app
but still then... its not really a big change to fix their expressions

[tandraschko]

Can you Test it in mojarra?

[volosied]

Mojarra 4.1.2 works without needing the prepended : -- it finds the component.

[tandraschko]

Then let me check it
In mojarra they use a invokeOnComponent Fallback, Leo optimized the algorithm in mf

[tandraschko]

+1
just proceed