sys/log: add format attribute to modlog_printf prototype #3530
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that there is pre-existing usage of |
ehaas
force-pushed
the
modlog-format-attribute
branch
2 times, most recently
from
346f7a1 to
1e70331
Compare
Add format(printf) attribute to modlog_printf to enable compile-time checking that format strings match arguments. Note that this will cause incorrect modlog_printf usage which previously compiled successfully, to no longer compile.
ehaas
force-pushed
the
modlog-format-attribute
branch
from
1e70331 to
acedf5a
Compare
|
@ehaas I think once the nimble PR is merged, the CI issues will get fixed. Let's wait for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add format(printf) attribute to modlog_printf to enable compile-time checking that format strings match arguments.
Note that this will cause incorrect modlog_printf usage which previously compiled successfully, to no longer compile.