Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

host/ble_gap.c : Check allowed random address #1611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

host/ble_gap.c : Check allowed random address #1611

wants to merge 1 commit into from

Conversation

rahult-github
Copy link
Contributor

Add a check to validate whether the random address being set is allowed as per spec

@rahult-github rahult-github force-pushed the bugfix/validate_random_address branch 4 times, most recently from a6f07a0 to 310d741 Compare September 20, 2023 02:57
@rahult-github rahult-github force-pushed the bugfix/validate_random_address branch from 310d741 to 72156d6 Compare October 3, 2023 06:05
@rahult-github
Copy link
Contributor Author

Hi @sjanc , can you please review this change.

@sjanc
Copy link
Contributor

sjanc commented Oct 10, 2023

I think this should be in some common code eg ble_hs_id.c ? Some helpers for generating and internal helpers for validating type of addresses.
There are similar checks for static random when calling ble_hs_id_set_rnd() etc

@rahult-github rahult-github force-pushed the bugfix/validate_random_address branch from 72156d6 to 395f404 Compare October 13, 2023 10:32
@rahult-github
Copy link
Contributor Author

I think this should be in some common code eg ble_hs_id.c ? Some helpers for generating and internal helpers for validating type of addresses. There are similar checks for static random when calling ble_hs_id_set_rnd() etc

Thanks for the review . I have made a generic function to check if passed address is as per spec or not.

@rahult-github
host/ble_gap.c : Check allowed random address
82660af 
Add a check to validate whether the random address being set is
allowed as per spec
@rahult-github rahult-github force-pushed the bugfix/validate_random_address branch from 395f404 to 82660af Compare October 19, 2023 06:12
@rahult-github
Copy link
Contributor Author

@sjanc , Please let me know if you have any more suggestions / comments.

@rymanluk
Copy link
Contributor

@sjanc ping

@rahult-github
Copy link
Contributor Author

Hi @sjanc , please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahult-github @sjanc @rymanluk