apps/blestress: extend functionality of blestress #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrnarajowski
force-pushed
the
console_input
branch
4 times, most recently
from
951aed9
to
5db6719
Compare
szymon-czapracki
suggested changes
Apr 11, 2024
| uint8_t dflt = 0; | ||
| int rc; | ||
|
|
||
| rc = parse_arg_init(argc - 1, argv +1); |
There was a problem hiding this comment.
Suggested change
| rc = parse_arg_init(argc - 1, argv +1); | |
| rc = parse_arg_init(argc - 1, argv + 1); |
Comment on lines
+794
to
+795
| .itvl_min = 0x0006,/*BLE_GAP_INITIAL_CONN_ITVL_MIN */ | ||
| .itvl_max = 0x0006,/*BLE_GAP_INITIAL_CONN_ITVL_MIN */ |
There was a problem hiding this comment.
Suggested change
| .itvl_min = 0x0006,/*BLE_GAP_INITIAL_CONN_ITVL_MIN */ | |
| .itvl_max = 0x0006,/*BLE_GAP_INITIAL_CONN_ITVL_MIN */ | |
| .itvl_min = 0x0006,/* BLE_GAP_INITIAL_CONN_ITVL_MIN */ | |
| .itvl_max = 0x0006,/* BLE_GAP_INITIAL_CONN_ITVL_MIN */ |
nitpick
Comment on lines
+1478
to
+1479
| } else { | ||
| rx_stress_start(test_case_num); |
There was a problem hiding this comment.
Is else here necessary? If test_case_num == 0 run those loops, otherwise just run rx_stress_start(test_case_num), or am I missing something?
Suggested change
| } else { | |
| rx_stress_start(test_case_num); | |
| } | |
| rx_stress_start(test_case_num); |
There was a problem hiding this comment.
The point was not to run rx_stress_start(0) after exiting the if statement
| void rx_stress_start_auto(); | ||
|
|
||
| #ifdef __cplusplus | ||
| } | ||
| #endif | ||
|
|
||
| #endif //_BLE_STRESS_RX_H | ||
| #endif /*_BLE_STRESS_RX_H */ |
There was a problem hiding this comment.
nitpick
Suggested change
| #endif /*_BLE_STRESS_RX_H */ | |
| #endif /* _BLE_STRESS_RX_H */ |
Comment on lines
+32
to
+34
| console_printf( | ||
| "\033[0;33mUse case 1 - " | ||
| "Stress Connect -> Connect Cancel: \n\033[0m"); |
There was a problem hiding this comment.
Suggested change
| console_printf( | |
| "\033[0;33mUse case 1 - " | |
| "Stress Connect -> Connect Cancel: \n\033[0m"); | |
| console_printf("\033[0;33mUse case 1 - " | |
| "Stress Connect -> Connect Cancel: \n\033[0m"); |
There was a problem hiding this comment.
Applies also in some places below.
Comment on lines
+35
to
+36
| console_printf("Con attempts = %d\n", | ||
| test_ctxs->con_stat[1].attempts_num); |
There was a problem hiding this comment.
Suggested change
| console_printf("Con attempts = %d\n", | |
| test_ctxs->con_stat[1].attempts_num); | |
| console_printf("Con attempts = %d\n", | |
| test_ctxs->con_stat[1].attempts_num); |
There was a problem hiding this comment.
Applies also in some places below.
| @@ -1640,13 +1647,13 @@ tx_stress_main_task_fn(void *arg) | |||
| assert(rc == 0); | |||
|
|
|||
| /* Start test 1 - Connect/Connect cancel */ | |||
| //tx_stress_test_perform(1); | |||
| /*tx_stress_test_perform(1); */ | |||
There was a problem hiding this comment.
nitpick
Suggested change
| /*tx_stress_test_perform(1); */ | |
| /* tx_stress_test_perform(1); */ |
This commit adds new enchancements to blestress app.
piotrnarajowski
force-pushed
the
console_input
branch
from
5db6719
to
590c588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds new enchancements to blestress app such as: