Fix condition in address recognition #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanc
reviewed
Oct 31, 2024
| if (operation.add_source.adv_addr.type != BLE_ADDR_PUBLIC || | ||
| operation.add_source.adv_addr.type != BLE_ADDR_RANDOM) { | ||
|
|
||
| if (!(operation.add_source.adv_addr.type != BLE_ADDR_PUBLIC || |
There was a problem hiding this comment.
so what is the intention here? which address types are allowed? 0x00 and 0x01?
Asking cause this check looks rather unorthodox...
This commit fixes logic for address recognition in add_source operation
szymon-czapracki
force-pushed
the
bass_address_fix
branch
from
a4d755e to
56b4d20
Compare
sjanc
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes logic for address
recognition in add_source operation