Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFIREG-395 - Implemented the ability to import and export versioned … #5107

Merged
merged 1 commit into from
Jun 9, 2021
Merged

NIFIREG-395 - Implemented the ability to import and export versioned … #5107

merged 1 commit into from
Jun 9, 2021

Conversation

mtien-apache
Copy link
Contributor

…flows through the UI.

  • Added REST endpoints in BucketFlowResource for importVersionedFlow and exportVersionedFlow.

  • Added import and export dialogs.

  • Set the initial value for the Bucket dropdown menu in the Import dialogs.

  • Added frontend and backend integration tests.

  • Created ExportedVersionedFlowSnapshot object.

  • Added test resource file and updated rat configuration to skip the file during contrib-check.

  • Refactored frontend and server side code.

  • Updated Flow Actions menu hover and focus styles.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@mtien-apache
NIFIREG-395 - Implemented the ability to import and export versioned …
22a3916 
…flows through the UI.

- Added REST endpoints in BucketFlowResource for importVersionedFlow and exportVersionedFlow.

- Added import and export dialogs.

- Set the initial value for the Bucket dropdown menu in the Import dialogs.

- Added frontend and backend integration tests.

- Created ExportedVersionedFlowSnapshot object.

- Added test resource file and updated rat configuration to skip the file during contrib-check.

- Refactored frontend and server side code.

- Updated Flow Actions menu hover and focus styles.
@mtien-apache mtien-apache mentioned this pull request May 27, 2021
Closed
12 tasks
@mtien-apache
Copy link
Contributor Author

@exceptionfactory @bbende @sardell @andrewmlim Would you review one more time? Opened a new PR after NiFi Registry was migrated into NiFi. There are no code changes on my end since your last reviews/approvals. Thanks!

@andrewmlim
Copy link
Contributor

+1 LGTM Ran through same test cases I did for apache/nifi-registry#319 including some basic authorization testing.

@sardell
Copy link
Contributor

sardell commented Jun 3, 2021

Taking another look now...

@sardell
Copy link
Contributor

sardell commented Jun 3, 2021

+1 (non-binding). LGTM!

@bbende
Copy link
Contributor

bbende commented Jun 3, 2021

+1 everything still looks good, nice work!

One minor thing I noticed while doing another test... in the first import, there is no box to specify Comments for the first version, but there is Flow Description which is technically a different field for the overall versioned flow, then on future imports of additional versions there is a Comments field. I'm in no way saying to hold this up, just wanted to note it for future consideration.

exceptionfactory
exceptionfactory approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mtien-apache!

@mtien-apache
Copy link
Contributor Author

One minor thing I noticed while doing another test... in the first import, there is no box to specify Comments for the first version, but there is Flow Description which is technically a different field for the overall versioned flow, then on future imports of additional versions there is a Comments field. I'm in no way saying to hold this up, just wanted to note it for future consideration.

@bbende Do you propose adding a Comments box in the dialog for 'Import New Flow' (first version)? I can create a separate JIRA for this. Thanks.

@bbende
Copy link
Contributor

bbende commented Jun 3, 2021

Yes I think it makes sense to allow it. It would be consistent with Start Version Control from NiFi which has a Description and Comments field for the first version.

@mtien-apache
Copy link
Contributor Author

Here is the JIRA (NIFI-8660) to allow adding Comments when importing a new flow.

@markap14
Copy link
Contributor

markap14 commented Jun 9, 2021

I see 4 +1's but no objections. Based on that, will merge.

@markap14 markap14 merged commit 69c10f5 into apache:main Jun 9, 2021
timeabarna pushed a commit to timeabarna/nifi that referenced this pull request Jul 6, 2021
@mtien-apache @timeabarna
NIFIREG-395 - Implemented the ability to import and export versioned …
86c60c7 
…flows through the UI. (apache#5107)

- Added REST endpoints in BucketFlowResource for importVersionedFlow and exportVersionedFlow.
- Added import and export dialogs.
- Set the initial value for the Bucket dropdown menu in the Import dialogs.
- Added frontend and backend integration tests.
- Created ExportedVersionedFlowSnapshot object.
- Added test resource file and updated rat configuration to skip the file during contrib-check.
- Refactored frontend and server side code.
- Updated Flow Actions menu hover and focus styles.
timeabarna pushed a commit to timeabarna/nifi that referenced this pull request Jul 21, 2021
@mtien-apache @timeabarna
NIFIREG-395 - Implemented the ability to import and export versioned …
94491a2 
…flows through the UI. (apache#5107)

- Added REST endpoints in BucketFlowResource for importVersionedFlow and exportVersionedFlow.
- Added import and export dialogs.
- Set the initial value for the Bucket dropdown menu in the Import dialogs.
- Added frontend and backend integration tests.
- Created ExportedVersionedFlowSnapshot object.
- Added test resource file and updated rat configuration to skip the file during contrib-check.
- Refactored frontend and server side code.
- Updated Flow Actions menu hover and focus styles.
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
@mtien-apache @krisztina-zsihovszki
NIFIREG-395 - Implemented the ability to import and export versioned …
8ca172f 
…flows through the UI. (apache#5107)

- Added REST endpoints in BucketFlowResource for importVersionedFlow and exportVersionedFlow.
- Added import and export dialogs.
- Set the initial value for the Bucket dropdown menu in the Import dialogs.
- Added frontend and backend integration tests.
- Created ExportedVersionedFlowSnapshot object.
- Added test resource file and updated rat configuration to skip the file during contrib-check.
- Refactored frontend and server side code.
- Updated Flow Actions menu hover and focus styles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mtien-apache @andrewmlim @sardell @bbende @markap14 @exceptionfactory