[bugfix] fix Make.dep result was Overwritten when there are too many files #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… many files Signed-off-by: xuxin19 <[email protected]>
according to the dependency of the .depend target, Make.dep is always generated additionally when src is modified. this will cause the Make.dep file to gradually increase in size during each incremental compilation, causing the Makefile to take longer to load. Signed-off-by: xuxin19 <[email protected]>
xiaoxiang781216
approved these changes
Aug 19, 2024
xiaoxiang781216
approved these changes
Aug 19, 2024
acassis
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
overwritten issue
when there are a lot of SRCS files and they are split into many batches,
the Make.dep file will be overwritten, causing incremental compilation exceptions.
incremental compile speed issue
when incremental compilation is performed, the contents of the Make.dep file will be repeated multiple times (because the incremental SRC changes will cause .depend to be executed).
this will cause additional overhead when Make.dep is parsed by GNU Make.
In the case I tested, Make.dep was incrementally compiled to more than 1G, slowing down the incremental compilation speed.
Impact
Testing
CI