build: Fix rpserver and rpproxy CMake builds #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For your visibility @acassis @xiaoxiang781216 |
|
hi @Jasinsky @xiaoxiang781216 nice catch! # in argtable3 CMakeLists
set_property(
TARGET nuttx
APPEND
PROPERTY NUTTX_INCLUDE_DIRECTORIES
${NUTTX_APPS_DIR}/system/argtable3/argtable3/src) |
Jasinsky
force-pushed
the
cmake_fix_rpserver_rpproxy
branch
from
37ee7ee
to
df744eb
Compare
|
@xiaoxiang781216 @xuxin930 - Thank you for your suggestion, applied - df744eb |
Jasinsky
force-pushed
the
cmake_fix_rpserver_rpproxy
branch
from
df744eb
to
30ed8ba
Compare
argtable3 include directories are appended as NUTTX_INCLUDE_DIRECTORIES property, symlink creation is no longer needed. Signed-off-by: Daniel Jasinski <[email protected]>
acassis
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes missing include directories for iperf application.
Make based build was able to proceed - CMake build had two aforementioned issues.
Impact
Hard to estimate.
Testing
Local playing around rpserver and rpproxy in sim flavor.