Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enable sim-02 build when we create or update a Complex PR #2767

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

lupyuen
Copy link
Member

@lupyuen lupyuen commented Oct 24, 2024

Summary

CI Build Job sim-02 was disabled to reduce our usage of GitHub Runners, to comply with ASF Policy: apache/nuttx#14376 (comment)

However this causes the Scheduled Merge Job to fail, due to reduced CI Checks: https://github.com/NuttX/nuttx/actions/runs/11490041505/job/31980056690#step:7:465

This PR re-enables sim-02 when we create or update a Complex PR.

Impact

When we create or update a Complex PR, the CI Workflow will now run sim-02, for improved CI Checking.

Testing

Creating a Complex PR now executes sim-02: https://github.com/lupyuen5/label-nuttx/actions/runs/11490590600?pr=82

CI Build Job sim-02 was disabled to reduce our usage of GitHub Runners, to comply with ASF Policy: apache/nuttx#14376 (comment)

However this causes the Scheduled Merge Job to fail, due to reduced CI Checks: https://github.com/NuttX/nuttx/actions/runs/11490041505/job/31980056690#step:7:465

This PR re-enables sim-02 when we create or update a Complex PR.
Copy link

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lupyuen! Go ahead and merge when ready :-)

@lupyuen lupyuen merged commit b6fb787 into apache:master Oct 24, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants