Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Skip jobs arm-08 to arm-14 when a Complex PR is created / updated #14386

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

lupyuen
Copy link
Member

@lupyuen lupyuen commented Oct 17, 2024

Summary

When we submit or update a Complex PR that affects All Architectures (Arm, RISC-V, Xtensa, etc): CI Workflow shall run only half the jobs. Previously CI Workflow will run arm-01 to arm-14, now we will run only arm-01 to arm-07.

When the Complex PR is Merged: CI Workflow will still run all jobs arm-01 to arm-14

Simple PRs with One Single Arch / Board will build the same way as before: arm-01 to arm-14

This is explained here: #14376

Note that this version of arch.yml has diverged from nuttx-apps, since we are unable to merge #14377

Impact

When we submit or update a Complex PR: CI Workflow shall run only half the jobs: arm-01 to arm-07 (instead of arm-01 to arm-14)

No changes to the CI Workflow when we merge a Complex PR. No impact for Simple PRs.

Testing

Creating a Simple PR will run jobs arm-01 to arm-14 (like before)
https://github.com/lupyuen5/label-nuttx/actions/runs/11380165777

Creating a Complex PR will only run jobs arm-01 to arm-07 (skipping arm-08 to arm-14)
https://github.com/lupyuen5/label-nuttx/actions/runs/11380214455

Merging a Complex PR will run all jobs arm-01 to arm-14 (like before)
https://github.com/lupyuen5/label-nuttx/actions/runs/11380246952

When we submit or update a Complex PR that affects All Architectures (Arm, RISC-V, Xtensa, etc): CI Workflow shall run only half the jobs. Previously CI Workflow will run `arm-01` to `arm-14`, now we will run only `arm-01` to `arm-07`.

When the Complex PR is Merged: CI Workflow will still run all jobs `arm-01` to `arm-14`

Simple PRs with One Single Arch / Board will build the same way as before: `arm-01` to `arm-14`

This is explained here: apache#14376

Note that this version of `arch.yml` has diverged from `nuttx-apps`, since we are unable to merge apache#14377
@github-actions github-actions bot added Area: CI Size: XS The size of the change in this PR is very small labels Oct 17, 2024
@lupyuen lupyuen linked an issue Oct 17, 2024 that may be closed by this pull request
@lupyuen
Copy link
Member Author

lupyuen commented Oct 17, 2024

Thanks @anchao for reviewing my PR! Right now it's a bit messy because this PR conflicts with #14377. So we have to decide which PR to merge first, then I'll update the second PR.

Really sorry for the rush, we are trying to cut down GitHub Costs before ASF shuts down our servers in 2 weeks. Thanks :-)

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lupyuen :-)

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lupyuen :-)

@cederom cederom merged commit 7aa7bf7 into apache:master Oct 18, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Size: XS The size of the change in this PR is very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[URGENT] Reducing our usage of GitHub Runners
3 participants