feat(core): Implement FromIterator for Buffer (#4459)

* feat(core): Implement FromIterator for Buffer Signed-off-by: Xuanwo <[email protected]> * Format code Signed-off-by: Xuanwo <[email protected]> --------- Signed-off-by: Xuanwo <[email protected]>
apache · Apr 10, 2024 · 0891924 · 0891924
1 parent 42a42f3
commit 0891924
Showing 1 changed file with 24 additions and 3 deletions.
diff --git a/core/src/types/buffer.rs b/core/src/types/buffer.rs
@@ -106,9 +106,15 @@ impl From<Bytes> for Buffer {
     }
 }
 
+impl FromIterator<u8> for Buffer {
+    fn from_iter<T: IntoIterator<Item = u8>>(iter: T) -> Self {
+        Self(Inner::Contiguous(Bytes::from_iter(iter)))
+    }
+}
+
 impl From<VecDeque<Bytes>> for Buffer {
     fn from(bs: VecDeque<Bytes>) -> Self {
-        let size = bs.iter().map(|b| b.len()).sum();
+        let size = bs.iter().map(Bytes::len).sum();
         Self(Inner::NonContiguous {
             parts: Vec::from(bs).into(),
             size,
@@ -120,7 +126,7 @@ impl From<VecDeque<Bytes>> for Buffer {
 
 impl From<Vec<Bytes>> for Buffer {
     fn from(bs: Vec<Bytes>) -> Self {
-        let size = bs.iter().map(|b| b.len()).sum();
+        let size = bs.iter().map(Bytes::len).sum();
         Self(Inner::NonContiguous {
             parts: bs.into(),
             size,
@@ -132,7 +138,7 @@ impl From<Vec<Bytes>> for Buffer {
 
 impl From<Arc<[Bytes]>> for Buffer {
     fn from(bs: Arc<[Bytes]>) -> Self {
-        let size = bs.iter().map(|b| b.len()).sum();
+        let size = bs.iter().map(Bytes::len).sum();
         Self(Inner::NonContiguous {
             parts: bs,
             size,
@@ -142,6 +148,21 @@ impl From<Arc<[Bytes]>> for Buffer {
     }
 }
 
+impl FromIterator<Bytes> for Buffer {
+    fn from_iter<T: IntoIterator<Item = Bytes>>(iter: T) -> Self {
+        let mut size = 0;
+        let bs = iter.into_iter().inspect(|v| size += v.len());
+        // Use `Arc::from_iter` here to make sure we can benefit from `TrustedLen` if provided.
+        let parts = Arc::from_iter(bs);
+        Self(Inner::NonContiguous {
+            parts,
+            size,
+            idx: 0,
+            offset: 0,
+        })
+    }
+}
+
 impl Buf for Buffer {
     #[inline]
     fn remaining(&self) -> usize {