-
Notifications
You must be signed in to change notification settings - Fork 499
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(services/fs,hdfs): fix poll_close when retry
- Loading branch information
Showing
7 changed files
with
180 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
[package] | ||
edition = "2021" | ||
license = "Apache-2.0" | ||
name = "edge_file_close_with_retry_on_full_disk" | ||
publish = false | ||
rust-version = "1.67" | ||
version = "0.0.0" | ||
|
||
[dependencies] | ||
futures = "0.3" | ||
opendal = { path = "../../" } | ||
rand = "0.8" | ||
tokio = { version = "1", features = ["full"] } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# File Close with Retry on Full Disk | ||
|
||
Reported by [fs::Writer::poll_close can't be retried multiple times when error occurs](https://github.com/apache/opendal/issues/4058). | ||
|
||
Setup: | ||
|
||
```shell | ||
fallocate -l 512K disk.img | ||
mkfs disk.img | ||
mkdir ./td | ||
sudo mount -o loop td.img ./td | ||
chmod a+wr ./td | ||
``` | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
use std::env; | ||
|
||
use opendal::layers::RetryLayer; | ||
use opendal::services::Fs; | ||
use opendal::Operator; | ||
use opendal::Result; | ||
use rand::prelude::*; | ||
|
||
#[tokio::main] | ||
async fn main() -> Result<()> { | ||
let mut builder = Fs::default(); | ||
builder.root(&env::var("OPENDAL_FS_ROOT").expect("root must be set for this test")); | ||
let op = Operator::new(builder)? | ||
.layer(RetryLayer::new().with_max_times(3)) | ||
.finish(); | ||
|
||
let size = thread_rng().gen_range(512 * 1024 + 1..4 * 1024 * 1024); | ||
let mut bs = vec![0; size]; | ||
thread_rng().fill_bytes(&mut bs); | ||
|
||
let mut w = op.writer("/test").await?; | ||
w.write(bs).await?; | ||
let result = w.close().await; | ||
// Write file with size > 512KB should fail | ||
assert!( | ||
result.is_err(), | ||
"close file with retry on full disk should return error" | ||
); | ||
|
||
Ok(()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters