Skip to content

Commit

Permalink
fix(services/oss,s3): Metadata should be marked as complete (#1335)
Browse files Browse the repository at this point in the history
fix(services/{oss,s3}): Metadata should be marked as complete

Signed-off-by: Xuanwo <[email protected]>
  • Loading branch information
Xuanwo authored Feb 13, 2023
1 parent c11dceb commit c266e9d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/services/oss/dir_stream.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ impl output::Page for DirStream {
if object.key.ends_with('/') {
continue;
}
let mut meta = ObjectMetadata::new(ObjectMode::FILE);
let mut meta = ObjectMetadata::new(ObjectMode::FILE).with_complete();

meta.set_etag(&object.etag);
meta.set_content_length(object.size);
Expand Down
2 changes: 1 addition & 1 deletion src/services/s3/dir_stream.rs
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ impl output::Page for DirStream {
continue;
}

let mut meta = ObjectMetadata::new(ObjectMode::FILE);
let mut meta = ObjectMetadata::new(ObjectMode::FILE).with_complete();

meta.set_etag(&object.etag);
meta.set_content_md5(object.etag.trim_matches('"'));
Expand Down

2 comments on commit c266e9d

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for opendal ready!

✅ Preview
https://opendal-lc1b0boms-databend.vercel.app

Built with commit c266e9d.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: c266e9d Previous: c11dceb Ratio
service_memory_read_full/256 KiB 34596 ns/iter (± 2248) 13951 ns/iter (± 16) 2.48
service_memory_write_once/256 KiB 96662 ns/iter (± 18981) 44032 ns/iter (± 309) 2.20

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Xuanwo

Please sign in to comment.