feat(bindings/cpp): make ReaderStream manage the lifetime of Reader (#…

…3164)

Signed-off-by: silver-ymz <[email protected]>

bindings/cpp/include/opendal.hpp

@@ -197,8 +197,7 @@ class Operator {
  * @details It provides basic read and seek operations. If you want to use it
  * like a stream, you can use `ReaderStream` instead.
  * @code{.cpp}
- * auto reader = operator.reader("path");
- * opendal::ReaderStream stream(reader);
+ * opendal::ReaderStream stream(operator.reader("path"));
  * @endcode
  */
 class Reader
@@ -221,15 +220,19 @@ class Reader
 /**
  * @class ReaderStream
  * @brief ReaderStream is a stream wrapper of Reader which can provide
- * `iostream` interface.
- * @note It's an undefined behavior to make multiple streams from one reader.
+ * `iostream` interface. It will keep a Reader inside so that you can ignore the
+ * lifetime of original Reader.
  */
 class ReaderStream
     : public boost::iostreams::stream<boost::reference_wrapper<Reader>> {
 public:
-  ReaderStream(Reader &reader)
+  ReaderStream(Reader &&reader)
       : boost::iostreams::stream<boost::reference_wrapper<Reader>>(
-            boost::ref(reader)) {}
+            boost::ref(reader_)),
+        reader_(std::move(reader)) {}
+
+private:
+  Reader reader_;
 };
 
 /**

bindings/cpp/tests/basic_test.cpp

@@ -117,7 +117,7 @@ TEST_F(OpendalTest, ReaderTest) {
   reader.seek(0, std::ios::beg);
 
   // stream
-  opendal::ReaderStream stream(reader);
+  opendal::ReaderStream stream(std::move(reader));
 
   auto read_fn = [&](std::size_t to_read, std::streampos expected_tellg) {
     std::vector<char> v(to_read);