-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oay): port WebdavFs
to dav-server-fs-opendal
#3119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Sep 18, 2023
Young-Flash
requested review from
suyanhanx,
tisonkun,
silver-ymz and
xyjixyjixyji
as code owners
September 19, 2023 14:16
Young-Flash
force-pushed
the
dav-server-fs-opendal
branch
from
September 19, 2023 14:21
860169f
to
785581c
Compare
Xuanwo
reviewed
Sep 21, 2023
Young-Flash
force-pushed
the
dav-server-fs-opendal
branch
from
September 21, 2023 11:08
bb8d0df
to
836ad64
Compare
Xuanwo
reviewed
Sep 21, 2023
Xuanwo
approved these changes
Oct 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, let's go!
This was referenced Oct 7, 2023
cc @Young-Flash, this PR is about to merge. Would you like to help make the clippy happy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3085
tracked in #2586
will update oay webdav service after this PR merged.