Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(binding): Add Apache 2.0 License in README.md in sub-directory #3486

Closed
wants to merge 1 commit into from
Closed

docs(binding): Add Apache 2.0 License in README.md in sub-directory #3486

wants to merge 1 commit into from

Conversation

caicancai
Copy link
Member

No description provided.

@Zheaoli
Copy link
Member

Zheaoli commented Nov 4, 2023 •
edited
Loading

Actually, I'm not sure we should add the license declaration in the subdirectory or not cc @Xuanwo

@Zheaoli Zheaoli changed the title [Improve] [Doc]add apahce2.0 license docs(binding): Add Apache 2.0 License in README.md in subdirectory Nov 4, 2023
@Zheaoli Zheaoli changed the title docs(binding): Add Apache 2.0 License in README.md in subdirectory docs(binding): Add Apache 2.0 License in README.md in sub-directory Nov 4, 2023
@caicancai
Copy link
Member Author

Actually, I'm we should add the license declaration in the subdirectory

Thank you for your correction

@caicancai
Copy link
Member Author

I found that some subdirectories are licensed and some are not, and maybe a unified standard is needed

@Xuanwo
Copy link
Member

Xuanwo commented Nov 4, 2023

Thanks for the contribution. But I feel like this PR is not meaningful. Welcome to improve other parts of OpenDAL 🥰

@caicancai
Copy link
Member Author

Thanks for the contribution. But I feel like this PR is not meaningful. Welcome to improve other parts of OpenDAL 🥰

thank you

@caicancai caicancai closed this Nov 4, 2023
@caicancai caicancai deleted the license branch November 7, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@messense messense Awaiting requested review from messense messense is a code owner

@oowl oowl Awaiting requested review from oowl oowl is a code owner

@tisonkun tisonkun Awaiting requested review from tisonkun tisonkun is a code owner

@Xuanwo Xuanwo Awaiting requested review from Xuanwo Xuanwo is a code owner

Assignees
No one assigned
Labels
releases-note/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caicancai @Zheaoli @Xuanwo