Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add dependencies list for all packages #3743

Merged
merged 8 commits into from
Dec 13, 2023
Merged

docs: Add dependencies list for all packages #3743

merged 8 commits into from
Dec 13, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 12, 2023

No description provided.

@tisonkun tisonkun requested a review from wu-sheng December 12, 2023 02:26
@xyjixyjixyji
Copy link
Contributor

Can we have just one DEPENDENCIES.rust.csv and let all places refering to this have its position instead of having several duplicates for all bindings?

tisonkun
tisonkun reviewed Dec 12, 2023
View reviewed changes
DEPENDENCIES.md Outdated Show resolved Hide resolved
@Xuanwo
Add dependcenices
69da8d5 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 12, 2023

Can we have just one DEPENDENCIES.rust.csv and let all places refering to this have its position instead of having several duplicates for all bindings?

Maintaining the differencies for every binding is much more complex. Please note, every packages' DEPENDENCIES.rust.csv are different.

tisonkun
tisonkun reviewed Dec 12, 2023
View reviewed changes
DEPENDENCIES.md Outdated Show resolved Hide resolved
tisonkun
tisonkun reviewed Dec 12, 2023
View reviewed changes
bin/oay/DEPENDENCIES.md Outdated Show resolved Hide resolved
tisonkun
tisonkun reviewed Dec 12, 2023
View reviewed changes
website/DEPENDENCIES.md Outdated Show resolved Hide resolved
@Xuanwo
Add CI
c1600bb 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix CI
01beb08 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Add check for website
c3972fc 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo mentioned this pull request Dec 12, 2023
Closed
11 tasks
oowl
oowl approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun tisonkun merged commit f725eb1 into main Dec 13, 2023
223 checks passed
@tisonkun tisonkun deleted the dependencies branch December 13, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oowl oowl oowl approved these changes

@PsiACE PsiACE PsiACE approved these changes

@tisonkun tisonkun tisonkun approved these changes

@messense messense Awaiting requested review from messense messense is a code owner

@Zheaoli Zheaoli Awaiting requested review from Zheaoli Zheaoli is a code owner

@suyanhanx suyanhanx Awaiting requested review from suyanhanx suyanhanx is a code owner

@silver-ymz silver-ymz Awaiting requested review from silver-ymz silver-ymz is a code owner

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

@wu-sheng wu-sheng Awaiting requested review from wu-sheng

Assignees
No one assigned
Labels
releases-note/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Xuanwo @xyjixyjixyji @tisonkun @suyanhanx @PsiACE @oowl