Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(cargo): Add frame pointer support in build flag #3772

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented Dec 18, 2023

The related discussion #3756

The main change of this PR is:

  1. Add force-frame-pointers=yes as default build flag
  2. Add build-std to rebuild the std lib

Signed-off-by: Manjusaka [email protected]

@Zheaoli Zheaoli force-pushed the manjusaka/support-framepointer branch from 1c4e68a to a0adf32 Compare December 18, 2023 13:05
@Zheaoli Zheaoli marked this pull request as draft December 18, 2023 13:12
.cargo/config Outdated Show resolved Hide resolved
@Zheaoli Zheaoli force-pushed the manjusaka/support-framepointer branch from 7b57c3c to fa74244 Compare December 18, 2023 16:21
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli Zheaoli marked this pull request as ready for review December 18, 2023 16:22
@Zheaoli
Copy link
Member Author

Zheaoli commented Dec 18, 2023

For now, the build-std flag is only supported in Rust nightly. I think it's not time to support it. So I remove the .cargo direcotry and put the RUSTFLAGS into ENV

@Xuanwo Xuanwo merged commit 62ca99d into main Dec 19, 2023
7 checks passed
@Xuanwo Xuanwo deleted the manjusaka/support-framepointer branch December 19, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants