-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: avoid hard dep to tokio rt #4061
Conversation
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
We need to make blocking layer under a feature gate instead. This is a breaking change. |
@Xuanwo I have an alternative idea. I'm investigating |
Signed-off-by: tison <[email protected]>
This reverts commit 64362a0.
Replacing tokio this way doesn't look good to me. I like the idea of using pollster, but I wish it to be a new layer like In this way, our users can decide which runtime to use by switching layers in the next version. |
This is the case. Switching to a feature flag solution. |
d8313ea
to
7d885c5
Compare
659142e
to
b9f161e
Compare
Signed-off-by: tison <[email protected]>
b9f161e
to
9e91d97
Compare
Signed-off-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, the only thing here is to add a upgrade entry in UPGRADE.md
since this is a breaking change.
Signed-off-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This closes #3948.
I'm trying to opt-out tokio deps as much as possible. But it surprises me that simply remove "rt" doesn't give compile error locally. Check CI workflow for more infos.