-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(services/memcached): change to binary protocal #4252
Conversation
core/Cargo.toml
Outdated
@@ -56,6 +56,7 @@ default = [ | |||
"services-webdav", | |||
"services-webhdfs", | |||
"services-azfile", | |||
"services-memcached", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add services in default set.
I'm not certain, but it seems like |
https://www.memcachier.com/documentation/supported-protocols-ascii-binary. |
That's great! We can remove ascii support. |
d7b5d73
to
31d17a2
Compare
68333ba
to
f483939
Compare
f483939
to
9db8dbe
Compare
9db8dbe
to
ae985b9
Compare
8ca86e7
to
2de5194
Compare
2de5194
to
ad44fe9
Compare
Would you like to add a test for memcached with password? And do we need sasl at client side? |
Yes, I will add it in another pr, we do not need sasl at client side. |
Got it. Let's move! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Part #4177
@Xuanwo Basically done, do you have any suggestions for users to use different protocols to access memcache? sasl is only available in bianry.