-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(services/github): add github contents support #4281
Conversation
6188cd4
to
37aa6a7
Compare
@Xuanwo When disable create_dir, op.create_dir("test/") will report this error {"message":"path cannot end with a slash","errors":[{"resource":"Commit","field":"path","code":"invalid"}],"documentation_url":"https://docs.github.com/rest/repos/contents#create-or-update-file-contents"} |
core/src/types/scheme.rs
Outdated
@@ -422,6 +425,7 @@ impl From<Scheme> for &'static str { | |||
Scheme::Postgresql => "postgresql", | |||
Scheme::Mysql => "mysql", | |||
Scheme::Gdrive => "gdrive", | |||
Scheme::Github => "github_contents", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Sad, let's create |
Should we remove .gitkeep from the list return? |
Yes, we can ignore |
acc8590
to
fbccaa2
Compare
3cb04fa
to
771c40c
Compare
771c40c
to
c90785d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Part #4253