Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bin/ofs): Add behavior test for ofs #4373

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Conversation

ho-229
Copy link
Contributor

@ho-229 ho-229 commented Mar 15, 2024

@ho-229 ho-229 requested review from Xuanwo and PsiACE as code owners March 15, 2024 12:42
@ho-229 ho-229 marked this pull request as draft March 15, 2024 12:42
@github-actions github-actions bot requested review from oowl and Young-Flash March 15, 2024 12:42
@ho-229 ho-229 marked this pull request as ready for review March 16, 2024 08:07
@ho-229
Copy link
Contributor Author

ho-229 commented Mar 16, 2024

cc @Xuanwo , can you rerun the workflows?

@ho-229 ho-229 force-pushed the test_ofs branch 4 times, most recently from acaacd6 to 5853a02 Compare March 28, 2024 12:32
@Xuanwo
Copy link
Member

Xuanwo commented Apr 1, 2024

Hi, I'm currently working on a significant refactor that I expect to complete this week. Would you like to wait the review until then? Thank you.

@ho-229 ho-229 closed this Apr 1, 2024
@ho-229 ho-229 reopened this Apr 1, 2024
@github-actions github-actions bot requested a review from morristai April 1, 2024 11:12
@ho-229
Copy link
Contributor Author

ho-229 commented Apr 1, 2024

Sure, thank you for your contributions to open source

@Xuanwo Xuanwo changed the title test: ofs feat(bin/ofs): Add behavior test for ofs Apr 9, 2024
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 333029c into apache:main Apr 9, 2024
308 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants